bugs for First Person Body Support (#1396)
Created by: yohjimane
All issues below effect branch #1396 and must be completed before we can merge.
-
1. mixed build errors, can cause first person body to appear floating. The second error occurs on dev branch in mixed builds too. - No longer an issue with new camera positioning method 9dd1ae265d8ff4876a8cc3dfe2c8b1b989d6154a
-
2. being around NPCs causes first person body position to deviate - fixed with 900c3270eba067e7ac24c08ec1a02ee53f90286e
-
3. possible to clip through object if facing away from them - No longer an issue new camera positioning method 9dd1ae265d8ff4876a8cc3dfe2c8b1b989d6154a
-
4. First person body position can "jitter" between original position and corrected position - fixed with 60ac2ea0fcbe1f6ce5700ba705ba015d70b78abd
- More info in discord msg
https://github.com/OpenXRay/xray-16/assets/11345783/ee1ac41c-4486-44b0-bace-916f6a16a68e
-
5. New jitter bug introduced with 60ac2ea0fcbe1f6ce5700ba705ba015d70b78abd - fixed with fcbac9fb0adbc78643f25b963e7cf5c8199fabb4
https://github.com/OpenXRay/xray-16/assets/11345783/8b4774a1-23a8-4ec2-9a6c-23ab96a110d8
-
6. First person body syncs at low frame rate in some conditions. I think it depends on whether or not our body can currently cast a shadow. Possibly some performance optimization we need to disable. -
fixed with c32e8662b700ca04089d774513ffbc97abcb1c7e
-
Can be easily reproduced with the settings:
r__actor_shadow off
andg_first_person_body on
-
In the video below, I am turning headlamp on, which causes the body to render smoothly. When it is off, the body renders at lower frame rate
https://github.com/OpenXRay/xray-16/assets/11345783/e9703f25-9b5d-4c62-baa3-11dc44fad134
-
7. Actor headlamp is in incorrect position - It needs to be corrected similarly to CWeapon position correction
- Would be best if we can find a generic solution that works for CWeapon, CTorch, CCustomDetector etc...
- fixed with new camera positioning method 9dd1ae265d8ff4876a8cc3dfe2c8b1b989d6154a
-
8. IK is incorrectly based on original position - It should be corrected using camera direction similarly to CWeapon position correction.
- fixed with new camera positioning method 9dd1ae265d8ff4876a8cc3dfe2c8b1b989d6154a