- 09.06.2016 3 коммита
-
-
Timothy Andrew создал -
Timothy Andrew создал
- Need to pass in a `page_slug` to the filter, so it can rewrite based on the current page (all links are rewritten to the level of the app root). - The earlier `markdown_preview` endpoint was at the level of the wiki. We need to know the current page (for rewriting, as above), so this commit moves the endpoint to the level of a wiki page. - Fix all tests
-
Timothy Andrew создал
Original Comments ================= - Linking behaves as per rules documented here: https://gitlab.com/gitlab-org/gitlab-ce/blob/16568-document-wiki-linking-behavior/doc/markdown/wiki.md - All links (to other wiki pages) are rewritten to be at the level of the app root. We can't use links relative to the current page ('./foo', 'foo', '../foo'), because they won't work in the markdown preview, where the current page is suffixed with `/edit` - Move existing `WikiLinkFilter` specs to `WikiPipeline` spec. It makes sense to run these tests on the combined output of the pipeline, rather than a single filter, since we can catch issues with conflicting filters. - Add more tests to cover the new linking @rymai's Review =============== - Classes nested under `WikiLinkFilter` should declare `WikiLinkFilter`'s inherit, so nothing changes if the nested class is loaded first. - Add a blank line after a guard clause - Use keyword arguments for the `Rewriter` constructor - Invert a condition - use `if` instead of `unless` - Inline a `let` in `WikiPipeline` spec - it was only used in a single place - Change out of date spec names - Add a comment for every rewrite rule in `Rewriter`
-
- 02.06.2016 11 коммитов
-
-
Robert Speicher создал
Load d3 only when necessary Now d3 is only loaded on the users' show page and the graphs pages, where it's necessary. Redo of !3993. This decreases page size from 4.6MB to 4.3MB for a given Activity page (before compression), or a savings of 300KB. This is essentially a proof of concept for removing larger dependencies such as the Ace Editor, Chart.js, and Raphael, which will likely provide another 1MB of savings on most pages (again, before compression). See merge request !4394
-
Robert Speicher создал
Remove Coveralls and Semaphore badges. [ci skip] Remove Coveralls and Semaphore badges from the README. They're outdated, unused, and not GitLab CI :) [ci skip] See merge request !4334
-
Connor Shea создал
-
Connor Shea создал
-
Connor Shea создал
-
Connor Shea создал
-
Connor Shea создал
-
Robert Speicher создал
Adds a `title` attribute to the branch dropdown for when the name has been cut off. Fixes #18056 See merge request !4395
-
Robert Speicher создал
Upgrade devise, devise-two-factor, and attr_encrypted Devise 4 includes support for Rails 5, working towards #14286. devise-async doesn't support Devise 4.0 and in 4.1 the bug that was blocking using Devise's built-in ActiveJob integration was fixed. So devise-async is removed. devise-two-factor 3.0.0 is required for Devise 4 support. attr_encrypted and encryptor are optional but recommended upgrades for devise-two-factor 3.0.0. The mode and algorithm will need to be changed in order to update to attr_encrypted 4.x in the future. See merge request !4216
-
Stan Hu создал
Use downcased path to container repository as this is expected path by Docker ## What does this MR do? Docker Engine requires path to be lowercase. This makes all container registry paths to be show and used downcased instead of mixed case. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17959 See merge request !4420
-
Jacob Schatz создал
Implement new row hover style ## What does this MR do? Implement new row hover style ## What are the relevant issue numbers? Closes #17187 ## Screenshots (if relevant)  cc @dzaporozhets See merge request !4422
-
- 01.06.2016 26 коммитов
-
-
Kamil Trzcinski создал
-
Kamil Trzcinski создал
-
Annabel Dunstone создал
-
Jacob Schatz создал
MR widget mobile styling ## What does this MR do? Corrects MR widget styling for mobile viewing. ## Are there points in the code the reviewer needs to double check? I have tested all MR states. ## Why was this MR needed? UX. ## What are the relevant issue numbers? Closes #17676. ## Screenshots (if relevant)  See merge request !4386
-
Stan Hu создал
Fix note validation spec failure Fix failing build due to project of note not matching issue project. See merge request !4415
-
Kamil Trzcinski создал
-
Jacob Schatz создал
Add Edge to supported browsers list. Add Microsoft's Edge browser to the list of supported browsers. We support the latest stable version. See merge request !4416
-
Connor Shea создал
-
Robert Speicher создал
Don't advertise the use of "ci skip" in the CONTRIBUTING guide [ci skip] See merge request !4406
-
Robert Speicher создал
Enable Style/Semicolon rubocop style cop Don't use semicolons to terminate expressions. See #17478. See merge request !4351
-
Robert Speicher создал
Enable Style/For rubocop cop > Do not use `for`, unless you know exactly why. Most of the time iterators should be used instead. `for` is implemented in terms of `each` (so you're adding a level of indirection), but with a twist - `for` doesn't introduce a new scope (unlike `each`) and variables defined in its block will be visible outside it. See #17478 See merge request !4397
-
Stan Hu создал
-
Dmitriy Zaporozhets создал
Merge Builds and Pipelines tab into one Based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4053#note_12064642. Main idea is to keep all CI-related pages under one tab. So we can keep top navigation clean. First I tried `CI/CD` naming but it looked weird so I just used Pipelines as tab name. I did not change project settings naming. cc @ayufan @markpundsack @jschatz1 See merge request !4340
-
Douwe Maan создал
Separate reference gathering from rendering This is a required step to allow batch processing when gathering references. This in turn would allow grabbing (for example) all mentioned users of an issue/merge request using a single query. cc @rspeicher @DouweM See merge request !3969
-
Yorick Peterse создал
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned us...
-
Douwe Maan создал
Fix cancelability and retriablity of pipeline with generic statuses Currently it's not possible to cancel or retry generic status since this is external thing to GitLab. This fixes shown actions of pipelines containing only these actions. See merge request !4380
-
Rémy Coutable создал
Use project that belongs to pipeline in view ## What does this MR do? This MR makes project in pipelines view match the one that pipeline has been created for. Closes #17943 See merge request !4376
-
Rémy Coutable создал
Now that we autoscale runner, we don't need to optimize for their usage anymore. Abusing of "ci skip", for instance for view changes can lead to broken specs, so let's just not use it! Signed-off-by:
Rémy Coutable <remy@rymai.me> -
Douwe Maan создал
-
Kamil Trzcinski создал
-
Douwe Maan создал
Make EmailsOnPushWorker use Sidekiq mailers queue A customer was having issues with EmailsOnPushWorker clogging the Sidekiq queues and merge requests not being handled quickly. While researching whether it would possible to spin up a separate Sidekiq task just to handle merge requests and other key functions, I found that this worker was using the default Sidekiq queue. Moving to the `mailers` queue makes it possible to de-prioritize this worker and give more weight to the others. See merge request !4390
-
Douwe Maan создал
Use `Snippet#to_reference` directly ## What does this MR do? Instead of hard coding snippet reference, we could just use the existing method for that. ## Why was this MR needed? To address https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4338#note_12166325 from @DouweM /cc @jschatz1 See merge request !4379
-
Douwe Maan создал
Pass the "Remember me" value to the 2FA token form Prior, if a user had 2FA enabled and checked the "Remember me" field, the setting was ignored because the OTP input was on a new form and the value was never passed. Closes #18000 See merge request !4369
-
Douwe Maan создал
-
Douwe Maan создал
Fix 404 page when viewing TODOs that contain milestones or labels in different projects A user viewing the TODOs page will see a 404 if there are mentioned milestones or labels in multiple different projects. This is likely a caching bug and only occurs when Markdown rendering occurs across multiple projects, which is why it's so tricky to reproduce. This is what I think is happening: 1. LabelReferenceFilter#references_in encounters label ~X for ProjectA and finds the label in the DB as id = 1. 2. LabelReferenceFilter.references_in yields [1, 'X', nil, ...] 3. Since project_ref is nil, AbstractReferenceFilter#project_from_ref_cache caches nil => ProjectA. 4. LabelReferenceFilter#references_in encounters label ~Y for ProjectB and finds the label in the DB as id = 2. 5. LabelReferenceFilter.references_in yields [2, 'Y', nil, ...] 6. AbstractReferenceFilter#project_from_ref_cache lookups nil and returns ProjectA. It was supposed to be ProjectB. 7. A is the wrong project, so the label lookup fails. This MR expands the `project_ref` to the right value as soon as we have it to avoid this caching bug. Closes #17898 See merge request !4312 -
Grzegorz Bizon создал
-