- 05.10.2015 16 коммитов
-
-
Yorick Peterse создал
-
Robert Speicher создал
Document known issue with Reply by email and multiple application servers. See merge request !1499
-
Dmitriy Zaporozhets создал
Revert "Merge branch 'projects' into 'master'" This reverts commit 2b493695, reversing changes made to b5c12f74. This reverts !1487 MR because it cause bugs on mobile devices cc @skyruler See merge request !1509
-
Marin Jankovski создал
-
Yorick Peterse создал
This ensures that blocks defines using "benchmark_subject" have access to methods defined using let/subject & friends.
-
Dmitriy Zaporozhets создал
-
Yorick Peterse создал
Basic RSpec/benchmark-ips powered benchmark suite Corresponding issue: #2909, see the commit messages for more details. A few things to note: 1. The current use of `subject` isn't exactly easy on the eyes due to them having to return a Proc, I'm not sure yet how (and if) we can work around this. 2. The maximum amount of iterations in the current `User.by_login` benchmark is arbitrary, we might have to adjust it once said method's performance has been improved. 3. Benchmarks currently take 2 seconds to warm up and 5 seconds to run (benchmark-ips defaults). 4. The custom RSpec matcher file (`benchmark_matchers.rb`) is a bit messy, any feedback on this would be appreciated Any comments/feedback on this would be greatly appreciated. See merge request !1503
-
Dmitriy Zaporozhets создал
Fix anchors to comments in diffs https://gitlab.com/gitlab-org/gitlab-ce/issues/2218 See merge request !1508
-
-
-
Valery Sizov создал
-
Yorick Peterse создал
-
Yorick Peterse создал
This will be disallowed again once the existing benchmarks pass (which relies on #2341).
-
-
Yorick Peterse создал
This class method can be used in "describe" blocks to specify the subject of a benchmark. This lets you write: benchmark_subject { Foo } instead of: benchmark_subject { -> { Foo } } -
-
- 04.10.2015 4 коммита
-
-
-
-
Guilherme Garnier создал
-
Guilherme Garnier создал
-
- 03.10.2015 7 коммитов
-
-
Guilherme Garnier создал
-
Dmitriy Zaporozhets создал
Fix bug where transferring a project would result in stale commit links Transferring a project to another namespace updates the project's updated_at field, but since the cache key did not depend on the object, the page fragments were not invalidated. This resulted in stale links to the commits. Changing the cache key to use the project pathname solves this issue. Closes gitlab-org/omnibus-gitlab#843 See merge request !1497
-
Dmitriy Zaporozhets создал
Improve project page height old thing. Grey block not aligned to the bottom. It was a scroll even with short project description.  New awesome stuff, no scroll, grey block aligned to the bottom.  See merge request !1487
-
Guilherme Garnier создал
-
Guilherme Garnier создал
-
Guilherme Garnier создал
-
Guilherme Garnier создал
-
- 02.10.2015 13 коммитов
-
-
Stan Hu создал
-
Stan Hu создал
Transferring a project to another namespace updates the project's updated_at field, but since the cache key did not depend on the object, the page fragments were not invalidated. This resulted in stale links to the commits. Changing the cache key to use the object pathname solves this issue. Closes gitlab-org/omnibus-gitlab#843
-
Andrey создал
-
Yorick Peterse создал
This benchmark suite uses benchmark-ips (https://github.com/evanphx/benchmark-ips) behind the scenes. Specs can be turned into benchmark specs by setting "benchmark" to "true" in the top-level describe block like so: describe SomeClass, benchmark: true do end Writing benchmarks can be done using custom RSpec matchers, for example: describe MaruTheCat, benchmark: true do describe '#jump_in_box' do it 'should run 1000 iterations per second' do maru = described_class.new expect { maru.jump_in_box }.to iterate_per_second(1000) end end end By default the "iterate_per_second" expectation requires a standard deviation under 30% (this is just an arbitrary default for now). You can change this by chaining "with_maximum_stddev" on the expectation: expect { maru.jump_in_box }.to iterate_per_second(1000) .with_maximum_stddev(10) This will change the expectation to require a maximum deviation of 10%. Alternatively you can use the it block style to write specs: describe MaruTheCat, benchmark: true do describe '#jump_in_box' do subject { -> { described_class.new } } it { is_expected.to iterate_per_second(1000) } end end Because "iterate_per_second" operates on a block, opposed to a static value, the "subject" method must return a Proc. This looks a bit goofy but I have been unable to find a nice way around this.
-
Dmitriy Zaporozhets создал
-
-
Dmitriy Zaporozhets создал
Fix: Wrong access level badge on MR comments https://gitlab.com/gitlab-org/gitlab-ce/issues/2654 See merge request !1501
-
Andrey создал
-
Douwe Maan создал
Throttle "Forgot your password?" emails Addresses internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2611 See merge request !1476
-
Yorick Peterse создал
If this directory were to be empty this would result in warnings being printed to STDERR, cluttering spec output. Doing this in Ruby fixes this problem (and also removes the need for shell alltogether).
-
Valery Sizov создал
-
Jacob Vosmaer создал
Back and forth permission on builds/ @jacobvosmaer I missed that :( See merge request !1500
-
Kamil Trzcinski создал
-