Merge branch 'maintain-milestone-filter' into 'master'

enable milestone filter to stick See merge request !2241

Merge branch 'maintain-milestone-filter' into 'master'
enable milestone filter to stick See merge request !2241
bbc28428 · Douwe Maan · 777771db · c73d55e1 · bbc28428 · bbc28428
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -59,6 +59,7 @@ v 8.3.3
  - Fix Error 500 when visiting build page of project with nil runners_token (Stan Hu)
  - Use WOFF versions of SourceSansPro fonts
  - Fix regression when builds were not generated for tags created through web/api interface
+  - Fix: maintain milestone filter between Open and Closed tabs (Greg Smethells)

 v 8.3.2
  - Disable --follow in `git log` to avoid loading duplicate commit data in infinite scroll (Stan Hu)

--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -266,7 +266,7 @@ def page_filter_path(options = {})
      state: params[:state],
      scope: params[:scope],
      label_name: params[:label_name],
-      milestone_id: params[:milestone_id],
+      milestone_title: params[:milestone_title],
      assignee_id: params[:assignee_id],
      author_id: params[:author_id],
      sort: params[:sort],