HTTP_REFERER not properly set in Safari

a7087cb9 · Valery Sizov · 6b028ed8 · a7087cb9 · a7087cb9 · a7087cb9
--- a/app/controllers/groups/hooks_controller.rb
+++ b/app/controllers/groups/hooks_controller.rb
@@ -38,7 +38,7 @@ def test
      flash[:alert] = 'Hook execution failed. Ensure the group has a project with commits.'
    end

-    redirect_to :back
+    redirect_back_or_default(default: { action: 'index' })
  end

  def destroy

--- a/app/controllers/groups/ldap_group_links_controller.rb
+++ b/app/controllers/groups/ldap_group_links_controller.rb
@@ -14,16 +14,19 @@ def create
      if request.referer && request.referer.include?('admin')
        redirect_to [:admin, @group], notice: 'New LDAP link saved'
      else
-        redirect_to :back, notice: 'New LDAP link saved'
+        redirect_back_or_default(default: { action: 'index' }, options: { notice: 'New LDAP link saved' })
      end
    else
-      redirect_to :back, alert: "Could not create new LDAP link: #{ldap_group_link.errors.full_messages * ', '}"
+      redirect_back_or_default(
+        default: { action: 'index' },
+        options: { alert: "Could not create new LDAP link: #{ldap_group_link.errors.full_messages * ', '}" }
+      )
    end
  end

  def destroy
    @group.ldap_group_links.where(id: params[:id]).destroy_all
-    redirect_to :back, notice: 'LDAP link removed'
+    redirect_back_or_default(default: { action: 'index' }, options: { notice: 'LDAP link removed' })
  end

  private

--- a/app/controllers/projects/approvers_controller.rb
+++ b/app/controllers/projects/approvers_controller.rb
@@ -9,6 +9,6 @@ def destroy
      project.approvers.find(params[:id]).destroy
    end
  
-    redirect_to :back
+    redirect_back_or_default(default: { action: 'index' })
  end
 end