Fix note validation spec failures

30aa6420 · Stan Hu · 2d084dd8 · 30aa6420 · 30aa6420
--- a/spec/models/commit_range_spec.rb
+++ b/spec/models/commit_range_spec.rb
@@ -151,9 +151,10 @@
      issue = create(:issue)

      create(:note_on_issue,
-             noteable_id: issue.id,
+             noteable: issue,
             system: true,
-             note: commit1.revert_description)
+             note: commit1.revert_description,
+             project: issue.project)

      expect_any_instance_of(Commit).to receive(:reverts_commit?).
        with(commit1).

--- a/spec/models/note_spec.rb
+++ b/spec/models/note_spec.rb
@@ -154,7 +154,7 @@
    context "confidential issues" do
      let(:user) { create :user }
      let(:confidential_issue) { create(:issue, :confidential, author: user) }
-      let(:confidential_note) { create :note, note: "Random", noteable: confidential_issue }
+      let(:confidential_note) { create :note, note: "Random", noteable: confidential_issue, project: confidential_issue.project }

      it "returns notes with matching content if user can see the issue" do
        expect(described_class.search(confidential_note.note, as_user: user)).to eq([confidential_note])