fixed autosize textarea height

fixed preview mode height not matching adding active icon

fixed autosize textarea height
fixed preview mode height not matching adding active icon
851550e1 · Phil Hughes · 3c1e8f20 · 851550e1 · 851550e1 · 851550e1
--- a/app/assets/javascripts/notes/components/issue_comment_form.vue
+++ b/app/assets/javascripts/notes/components/issue_comment_form.vue
@@ -237,7 +237,9 @@
 </script>

 <template>
-  <div :class="{ 'is-floating': floatingModeEnabled }">
+  <div
+    :class="{ 'is-floating': floatingModeEnabled }"
+  >
    <issue-note-signed-out-widget v-if="!isLoggedIn" />
    <ul
      v-else

--- a/app/assets/javascripts/vue_shared/components/markdown/header.vue
+++ b/app/assets/javascripts/vue_shared/components/markdown/header.vue
@@ -41,6 +41,11 @@

        this.$emit('toggleFloatingMode');
      },
+      toggleFullScreen() {
+        if (this.floatingModeEnabled) {
+          this.toggleFloatingMode();
+        }
+      },
    },
    mounted() {
      $(document).on('markdown-preview:show.vue', this.toggleMarkdownPreview);
@@ -122,7 +127,11 @@
            @click="toggleFloatingMode"
          >
            <i
-              class="fa fa-window-restore"
+              class="fa"
+              :class="{
+                'fa-window-restore': !floatingModeEnabled,
+                'fa-window-maximize': floatingModeEnabled,
+              }"
              aria-hidden="true">
            </i>
          </button>
@@ -133,7 +142,9 @@
            data-container="body"
            tabindex="-1"
            title="Go full screen"
-            type="button">
+            type="button"
+            @click="toggleFullScreen"
+          >
            <i
              aria-hidden="true"
              class="fa fa-arrows-alt fa-fw">

--- a/app/assets/stylesheets/framework/markdown_area.scss
+++ b/app/assets/stylesheets/framework/markdown_area.scss
@@ -78,7 +78,7 @@
 }

 .md-preview-holder {
-  min-height: 167px;
+  min-height: 171px;
  padding: 10px 0;
  overflow-x: auto;
 }

--- a/app/assets/stylesheets/pages/notes.scss
+++ b/app/assets/stylesheets/pages/notes.scss
@@ -836,5 +836,9 @@ ul.notes {
    margin-top: -1px;
    background-color: $white-light;
    border-top: 1px solid $white-normal;
+
+    .note-textarea {
+      height: 140px !important; // Need !important to override inline styles from autosize.js
+    }
  }
 }