Merge branch '66368-remove-unnecessary-check-in-mr-hook' into 'master'

Remove unneeded check for merge_request.project Closes #66368 See merge request gitlab-org/gitlab-ce!32086

Merge branch '66368-remove-unnecessary-check-in-mr-hook' into 'master'
Remove unneeded check for merge_request.project Closes #66368 See merge request gitlab-org/gitlab-ce!32086
de7328b1 · Jan Provaznik · 34bf7df0 · 0e274dfc · de7328b1
--- a/app/services/merge_requests/base_service.rb
+++ b/app/services/merge_requests/base_service.rb
@@ -17,11 +17,9 @@ def hook_data(merge_request, action, old_rev: nil, old_associations: {})
    end

    def execute_hooks(merge_request, action = 'open', old_rev: nil, old_associations: {})
-      if merge_request.project
-        merge_data = hook_data(merge_request, action, old_rev: old_rev, old_associations: old_associations)
-        merge_request.project.execute_hooks(merge_data, :merge_request_hooks)
-        merge_request.project.execute_services(merge_data, :merge_request_hooks)
-      end
+      merge_data = hook_data(merge_request, action, old_rev: old_rev, old_associations: old_associations)
+      merge_request.project.execute_hooks(merge_data, :merge_request_hooks)
+      merge_request.project.execute_services(merge_data, :merge_request_hooks)
    end

    def cleanup_environments(merge_request)