Fix GitAccess.

5d6af36f · Douwe Maan · 501e1215 · 5d6af36f · 5d6af36f
--- a/lib/gitlab/git_access.rb
+++ b/lib/gitlab/git_access.rb
@@ -136,7 +136,7 @@ def change_access_check(change)
        end

      unless user.can?(action, project)
-        return
+        status =
          case action
          when :force_push_code_to_protected_branches
            build_status_object(false, "You are not allowed to force push code to a protected branch on this project.")
@@ -148,7 +148,8 @@ def change_access_check(change)
            build_status_object(false, "You are not allowed to change existing tags on this project.")
          else # :push_code
            build_status_object(false, "You are not allowed to push code to this project.")
-          end
+          end 
+        return status
      end

      build_status_object(true)

--- a/spec/lib/gitlab/git_access_spec.rb
+++ b/spec/lib/gitlab/git_access_spec.rb
@@ -115,18 +115,10 @@
      let(:actor) { key }

      context 'pull code' do
-        context 'allowed' do
-          before { key.projects << project }
-          subject { access.download_access_check }
-
-          it { expect(subject.allowed?).to be_truthy }
-        end
-
-        context 'denied' do
-          subject { access.download_access_check }
+        before { key.projects << project }
+        subject { access.download_access_check }

-          it { expect(subject.allowed?).to be_falsey }
-        end
+        it { expect(subject.allowed?).to be_truthy }
      end
    end
  end