Merge branch 'ph-even-more-dispatcher-imports' into 'master'

Added imports for dispatcher routes See merge request gitlab-org/gitlab-ce!16640

Merge branch 'ph-even-more-dispatcher-imports' into 'master'
Added imports for dispatcher routes See merge request gitlab-org/gitlab-ce!16640
47f6dbdf · Filipa Lacerda · 0f5f77a0 · e22c007f · 47f6dbdf · 47f6dbdf
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
 /* eslint-disable func-names, space-before-function-paren, no-var, prefer-arrow-callback, wrap-iife, no-shadow, consistent-return, one-var, one-var-declaration-per-line, camelcase, default-case, no-new, quotes, no-duplicate-case, no-case-declarations, no-fallthrough, max-len */
-import notificationsDropdown from './notifications_dropdown';
-import LineHighlighter from './line_highlighter';
 import MergeRequest from './merge_request';
 import Flash from './flash';
-import BlobViewer from './blob/viewer/index';
 import GfmAutoComplete from './gfm_auto_complete';
-import Star from './star';
 import ZenMode from './zen_mode';
-import PerformanceBar from './performance_bar';
 import initNotes from './init_notes';
 import initIssuableSidebar from './init_issuable_sidebar';
 import { convertPermissionToBoolean } from './lib/utils/common_utils';
@@ -621,23 +616,12 @@ import SearchAutocomplete from './search_autocomplete';
                .then(callDefault)
                .catch(fail);
              break;
-            case 'show':
-              new Star();
-              notificationsDropdown();
-              break;
            case 'wikis':
              import('./pages/projects/wikis')
                .then(callDefault)
                .catch(fail);
              shortcut_handler = true;
              break;
-            case 'snippets':
-              if (path[2] === 'show') {
-                new ZenMode();
-                new LineHighlighter();
-                new BlobViewer();
-              }
-              break;
          }
          break;
      }
@@ -647,7 +631,9 @@ import SearchAutocomplete from './search_autocomplete';
      }

      if (document.querySelector('#peek')) {
-        new PerformanceBar({ container: '#peek' });
+        import('./performance_bar')
+          .then(m => new m.default({ container: '#peek' })) // eslint-disable-line new-cap
+          .catch(fail);
      }
    };


--- a/app/assets/javascripts/pages/projects/show/index.js
+++ b/app/assets/javascripts/pages/projects/show/index.js
@@ -5,8 +5,12 @@ import TreeView from '~/tree';
 import BlobViewer from '~/blob/viewer/index';
 import Activities from '~/activities';
 import { ajaxGet } from '~/lib/utils/common_utils';
+import Star from '../../../star';
+import notificationsDropdown from '../../../notifications_dropdown';

 export default () => {
+  new Star(); // eslint-disable-line no-new
+  notificationsDropdown();
  new ShortcutsNavigation(); // eslint-disable-line no-new
  new NotificationsForm(); // eslint-disable-line no-new
  new UserCallout({ // eslint-disable-line no-new

--- a/app/assets/javascripts/pages/projects/snippets/show/index.js
+++ b/app/assets/javascripts/pages/projects/snippets/show/index.js
 import initNotes from '~/init_notes';
 import ZenMode from '~/zen_mode';
+import LineHighlighter from '../../../../line_highlighter';
+import BlobViewer from '../../../../blob/viewer';

 export default function () {
+  new LineHighlighter(); // eslint-disable-line no-new
+  new BlobViewer(); // eslint-disable-line no-new
  initNotes();
  new ZenMode(); // eslint-disable-line no-new
 }
--- a/app/views/layouts/_head.html.haml
+++ b/app/views/layouts/_head.html.haml
@@ -43,7 +43,6 @@
  = webpack_bundle_tag "main"
  = webpack_bundle_tag "raven" if current_application_settings.clientside_sentry_enabled
  = webpack_bundle_tag "test" if Rails.env.test?
-  = webpack_bundle_tag 'performance_bar' if performance_bar_enabled?

  - if content_for?(:page_specific_javascripts)
    = yield :page_specific_javascripts

--- a/config/webpack.config.js
+++ b/config/webpack.config.js
@@ -85,7 +85,6 @@ var config = {
    test:                 './test.js',
    two_factor_auth:      './two_factor_auth.js',
    users:                './users/index.js',
-    performance_bar:      './performance_bar.js',
    webpack_runtime:      './webpack.js',
  },

@@ -119,9 +118,9 @@ var config = {
      {
        test: /\_worker\.js$/,
        use: [
-          { 
+          {
            loader: 'worker-loader',
-            options: { 
+            options: {
              inline: true
            }
          },