Allow JupyterHub to be uninstalled

- enabled uninstallation - give it a specific uninstall message - ajust specs

Allow JupyterHub to be uninstalled
- enabled uninstallation - give it a specific uninstall message - ajust specs
30ede575 · João Cunha · Mayra Cabrera · e1a6b9f9 · 30ede575 · 30ede575
--- a/app/assets/javascripts/clusters/components/uninstall_application_confirmation_modal.vue
+++ b/app/assets/javascripts/clusters/components/uninstall_application_confirmation_modal.vue
@@ -14,7 +14,9 @@ const CUSTOM_APP_WARNING_TEXT = {
  [PROMETHEUS]: s__('ClusterIntegration|All data will be deleted and cannot be restored.'),
  [RUNNER]: s__('ClusterIntegration|Any running pipelines will be canceled.'),
  [KNATIVE]: s__('ClusterIntegration|The associated IP will be deleted and cannot be restored.'),
-  [JUPYTER]: '',
+  [JUPYTER]: s__(
+    'ClusterIntegration|All data not committed to GitLab will be deleted and cannot be restored.',
+  ),
 };

 export default {

--- a/app/models/clusters/applications/jupyter.rb
+++ b/app/models/clusters/applications/jupyter.rb
@@ -40,12 +40,6 @@ def values
        content_values.to_yaml
      end

-      # Will be addressed in future MRs
-      # We need to investigate and document what will be permanently deleted.
-      def allowed_to_uninstall?
-        false
-      end
-
      def install_command
        Gitlab::Kubernetes::Helm::InstallCommand.new(
          name: name,

--- a/changelogs/unreleased/feature-uninstall_jupyter_hub_app.yml
+++ b/changelogs/unreleased/feature-uninstall_jupyter_hub_app.yml
+---
+title: Allow JupyterHub to be uninstalled from the UI
+merge_request: 30097
+author:
+type: added
--- a/doc/user/clusters/applications.md
+++ b/doc/user/clusters/applications.md
@@ -251,6 +251,7 @@ The applications below can be uninstalled.

 | Application | GitLab version | Notes |
 | ----------- | -------------- | ----- |
+| JupyterHub  | 12.1+         | All data not committed to GitLab will be deleted and cannot be restored. |
 | Prometheus  | 11.11+         | All data will be deleted and cannot be restored. |

 To uninstall an application:
@@ -287,4 +288,3 @@ To avoid installation errors:
  kubectl get secrets/tiller-secret -n gitlab-managed-apps -o "jsonpath={.data['ca\.crt']}" | base64 -d > b.pem
  diff a.pem b.pem
  ```
-
--- a/locale/gitlab.pot
+++ b/locale/gitlab.pot
@@ -2272,6 +2272,9 @@ msgstr ""
 msgid "ClusterIntegration|Advanced options on this Kubernetes cluster's integration"
 msgstr ""

+msgid "ClusterIntegration|All data not committed to GitLab will be deleted and cannot be restored."
+msgstr ""
+
 msgid "ClusterIntegration|All data will be deleted and cannot be restored."
 msgstr ""


--- a/spec/models/clusters/applications/jupyter_spec.rb
+++ b/spec/models/clusters/applications/jupyter_spec.rb
@@ -16,7 +16,7 @@

    subject { jupyter.can_uninstall? }

-    it { is_expected.to be_falsey }
+    it { is_expected.to be_truthy }
  end

  describe '#set_initial_status' do