Не подтверждена Коммит 2fe57353 создал по автору Nick Thomas's avatar Nick Thomas
Просмотр файлов

Avoid array indices to fixtures in JS specs

владелец bbe00038
Скрыть пробелы
Построчно Рядом
spec/javascripts/commit/pipelines/pipelines_spec.js
Просмотр файла @ 2fe57353
......@@ -10,9 +10,10 @@ describe('Pipelines table in Commits and Merge requests', () => {
preloadFixtures(jsonFixtureName);
beforeEach(() => {
const pipelines = getJSONFixture(jsonFixtureName).pipelines;
PipelinesTable = Vue.extend(pipelinesTable);
const pipelines = getJSONFixture(jsonFixtureName).pipelines; // sorted by id, descending
pipeline = pipelines[2];
pipeline = pipelines.find(p => p.user !== null && p.commit !== null);
});
describe('successful request', () => {
......
spec/javascripts/pipelines/pipelines_table_row_spec.js
Просмотр файла @ 2fe57353
......@@ -23,10 +23,11 @@ describe('Pipelines Table Row', () => {
preloadFixtures(jsonFixtureName);
beforeEach(() => {
const pipelines = getJSONFixture(jsonFixtureName).pipelines; // sorted by id, descending
pipeline = pipelines[2];
pipelineWithoutAuthor = pipelines[1];
pipelineWithoutCommit = pipelines[0];
const pipelines = getJSONFixture(jsonFixtureName).pipelines;
pipeline = pipelines.find(p => p.user !== null && p.commit !== null);
pipelineWithoutAuthor = pipelines.find(p => p.user == null && p.commit !== null);
pipelineWithoutCommit = pipelines.find(p => p.user == null && p.commit == null);
});
afterEach(() => {
......
spec/javascripts/pipelines/pipelines_table_spec.js
Просмотр файла @ 2fe57353
......@@ -11,9 +11,10 @@ describe('Pipelines Table', () => {
preloadFixtures(jsonFixtureName);
beforeEach(() => {
const pipelines = getJSONFixture(jsonFixtureName).pipelines;
PipelinesTableComponent = Vue.extend(pipelinesTableComp);
const pipelines = getJSONFixture(jsonFixtureName).pipelines; // ordered by id, descending
pipeline = pipelines[2];
pipeline = pipelines.find(p => p.user !== null && p.commit !== null);
});
describe('table', () => {
......
Поддерживает Markdown
0% или .
You are about to add 0 people to the discussion. Proceed with caution.
Сначала завершите редактирование этого сообщения!
Пожалуйста, зарегистрируйтесь или чтобы прокомментировать