Improve performance for pipeline charts

Achieved by using another table, which both has better indexes and is smaller. Now the data provided for the user is more valueable too.

Improve performance for pipeline charts
Achieved by using another table, which both has better indexes and is smaller. Now the data provided for the user is more valueable too.
13d39971 · Z.J. van de Weg · 9c7bf123 · 13d39971 · 13d39971 · 13d39971
--- a/app/controllers/projects/pipelines_controller.rb
+++ b/app/controllers/projects/pipelines_controller.rb
@@ -136,6 +136,11 @@ def charts
    @charts[:month] = Ci::Charts::MonthChart.new(project)
    @charts[:year] = Ci::Charts::YearChart.new(project)
    @charts[:build_times] = Ci::Charts::BuildTime.new(project)
+
+    @counts = {}
+    @counts[:total] = @project.pipelines.count(:all)
+    @counts[:success] = @project.pipelines.success.count(:all)
+    @counts[:failed] = @project.pipelines.failed.count(:all)
  end

  private

--- a/app/helpers/graph_helper.rb
+++ b/app/helpers/graph_helper.rb
@@ -17,13 +17,10 @@ def parents_zip_spaces(parents, parent_spaces)
    ids.zip(parent_spaces)
  end

-  def success_ratio(success_builds, failed_builds)
-    failed_builds = failed_builds.count(:all)
-    success_builds = success_builds.count(:all)
+  def success_ratio(success:, failed:)
+    return 100 if failed.zero?

-    return 100 if failed_builds.zero?
-
-    ratio = (success_builds.to_f / (success_builds + failed_builds)) * 100
+    ratio = (success.to_f / (success + failed)) * 100
    ratio.to_i
  end
 end
--- a/app/views/projects/pipelines/charts/_overall.haml
+++ b/app/views/projects/pipelines/charts/_overall.haml
@@ -2,18 +2,14 @@
 %ul
  %li
    Total:
-    %strong= pluralize @project.builds.count(:all), 'job'
+    %strong= pluralize @counts[:total], 'job'
  %li
    Successful:
-    %strong= pluralize @project.builds.success.count(:all), 'job'
+    %strong= pluralize @counts[:success], 'job'
  %li
    Failed:
-    %strong= pluralize @project.builds.failed.count(:all), 'job'
+    %strong= pluralize @counts[:failed], 'job'
  %li
    Success ratio:
    %strong
-      #{success_ratio(@project.builds.success, @project.builds.failed)}%
-  %li
-    Commits covered:
-    %strong
-      = @project.pipelines.count(:all)
+      #{success_ratio(@counts)}%
--- a/changelogs/unreleased/zj-faster-charts-page.yml
+++ b/changelogs/unreleased/zj-faster-charts-page.yml
+---
+title: Improve performance of the pipeline charts page
+merge_request: 12378
+author:
--- a/lib/ci/charts.rb
+++ b/lib/ci/charts.rb
@@ -3,7 +3,7 @@ module Charts
    module DailyInterval
      def grouped_count(query)
        query
-          .group("DATE(#{Ci::Build.table_name}.created_at)")
+          .group("DATE(#{Ci::Pipeline.table_name}.created_at)")
          .count(:created_at)
          .transform_keys { |date| date.strftime(@format) }
      end
@@ -17,12 +17,12 @@ module MonthlyInterval
      def grouped_count(query)
        if Gitlab::Database.postgresql?
          query
-            .group("to_char(#{Ci::Build.table_name}.created_at, '01 Month YYYY')")
+            .group("to_char(#{Ci::Pipeline.table_name}.created_at, '01 Month YYYY')")
            .count(:created_at)
            .transform_keys(&:squish)
        else
          query
-            .group("DATE_FORMAT(#{Ci::Build.table_name}.created_at, '01 %M %Y')")
+            .group("DATE_FORMAT(#{Ci::Pipeline.table_name}.created_at, '01 %M %Y')")
            .count(:created_at)
        end
      end
@@ -46,8 +46,8 @@ def initialize(project)
      end

      def collect
-        query = project.builds
-          .where("? > #{Ci::Build.table_name}.created_at AND #{Ci::Build.table_name}.created_at > ?", @to, @from)
+        query = project.pipelines
+          .where("? > #{Ci::Pipeline.table_name}.created_at AND #{Ci::Pipeline.table_name}.created_at > ?", @to, @from)

        totals_count  = grouped_count(query)
        success_count = grouped_count(query.success)