Gitlab::JsonCache#parse_value ensure string

03220c00 · Ash McKenzie · adeccba1 · 03220c00 · 03220c00
--- a/lib/gitlab/json_cache.rb
+++ b/lib/gitlab/json_cache.rb
@@ -58,7 +58,7 @@ def fetch(key, options = {}, &block)
    private

    def parse_value(raw, klass)
-      value = ActiveSupport::JSON.decode(raw)
+      value = ActiveSupport::JSON.decode(raw.to_s)

      case value
      when Hash then parse_entry(value, klass)

--- a/spec/lib/gitlab/json_cache_spec.rb
+++ b/spec/lib/gitlab/json_cache_spec.rb
@@ -106,6 +106,16 @@
      expect(cache.read(key)).to be_nil
    end

+    context 'when the cached value is a boolean' do
+      it 'parses the cached value' do
+        allow(backend).to receive(:read)
+          .with(expanded_key)
+          .and_return(true)
+
+        expect(cache.read(key, BroadcastMessage)).to eq(true)
+      end
+    end
+
    context 'when the cached value is a hash' do
      it 'parses the cached value' do
        allow(backend).to receive(:read)