Merge branch 'qa/be-explicit-when-fabricating-resources-via-api' into 'master'

Make tests explicitly fabricate resources via the API See merge request gitlab-org/gitlab-ce!30515

Merge branch 'qa/be-explicit-when-fabricating-resources-via-api' into 'master'
Make tests explicitly fabricate resources via the API See merge request gitlab-org/gitlab-ce!30515
713cc99a · Sanad Liaquat · 8a33f51d · a20f9796 · 713cc99a · 713cc99a
--- a/qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb
@@ -7,15 +7,15 @@ module QA
        Runtime::Browser.visit(:gitlab, Page::Main::Login)
        Page::Main::Login.act { sign_in_using_credentials }

-        source_group = Resource::Group.fabricate! do |group|
+        source_group = Resource::Group.fabricate_via_api! do |group|
          group.path = 'source-group'
        end

-        target_group = Resource::Group.fabricate! do |group|
+        target_group = Resource::Group.fabricate_via_api! do |group|
          group.path = 'target-group'
        end

-        project = Resource::Project.fabricate! do |project|
+        project = Resource::Project.fabricate_via_api! do |project|
          project.group = source_group
          project.name =  'transfer-project'
          project.initialize_with_readme = true

--- a/qa/qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb
@@ -9,7 +9,7 @@ module QA

        user = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)

-        project = Resource::Project.fabricate! do |resource|
+        project = Resource::Project.fabricate_via_api! do |resource|
          resource.name = 'add-member-project'
        end
        project.visit!