• S sverchok
  • Информация о проекте
    • Информация о проекте
    • Активность
    • Метки
    • Участники
  • Репозиторий
    • Репозиторий
    • Файлы
    • Коммиты
    • Ветки
    • Теги
    • Участники
    • Диаграмма
    • Сравнение
  • Задачи 148
    • Задачи 148
    • Список
    • Доски
    • Спринты
  • Запросы на слияние 21
    • Запросы на слияние 21
  • CI/CD
    • CI/CD
    • Конвейеры
    • Задания
    • Расписания
  • Развертывания
    • Развертывания
    • Окружения
    • Релизы
  • Пакеты и реестры
    • Пакеты и реестры
    • Реестр пакетов
    • Реестр контейнеров
  • Мониторинг
    • Мониторинг
    • Инциденты
  • Аналитика
    • Аналитика
    • Поток ценности
    • CI/CD
    • Репозиторий
  • Wiki
    • Wiki
  • Сниппеты
    • Сниппеты
  • Активность
  • Диаграмма
  • Создать новую задачу
  • Задания
  • Коммиты
  • Доски с задачами
Свернуть панель
  • nikitronn
  • sverchok
  • Запросы на слияние
  • !4620

Branch update json_examples/** node names

  • Ревью изменений

  • Скачать
  • Почтовые патчи
  • Простое отличие
Слиты nikitronn запросил слияние github/fork/satabol/Branch_update_templates_and_examples_node_names в master Авг 24, 2022
  • Обзор 37
  • Коммиты 9
  • Конвейеры 0
  • Изменения 55

Created by: satabol

Addressed problem description

  1. Update nodes names: Make monotone -> Make Monotone Delaunay 2D Cdt (Random points on mesh) -> Delaunay 2D Cdt // This is a triangulation Align mesh by mesh -> Align Mesh by Mesh

  2. Update Node Names and Tests of json_examples. Some examples has errors. I don't know - is it old examples or my mistakes? I think that error nodes are too old but may be I'm wrong. Please check me?

== Advanced ==============================

sverchok\json_examples\Advanced\Candy.json - good sverchok\json_examples\Advanced\Circle_fitting_physics.json - good sverchok\json_examples\Advanced\Genetic_algorithm_scripted_node.json - good sverchok\json_examples\Advanced\Genetic_algorithm_simple.json - good sverchok\json_examples\Advanced\Grain.json - good

sverchok\json_examples\Advanced\Open4d_mesh.json - errors Looking for GlslTexture 2022-08-24 17:45:54,832 [WARNING] sverchok.utils.sv_json_import 317: During import next fails has happened: FAIL: Init node (main tree) - 10 FAIL: Build link (main tree) - 18 2022-08-24 17:45:54,835 [ERROR] sverchok.core.update_system 399: 'NodeSocket' object has no attribute 'sv_forget'

sverchok\json_examples\Advanced\Petri_Spiral_Voronoi.json - good sverchok\json_examples\Advanced\PointsONmeshINlines.json - good sverchok\json_examples\Advanced\Pineapple.zip.json - good

================================================================

sverchok\json_examples\Architecture\BIM_ArchiCAD24_import.json - errors [ERROR] sverchok.nodes.script.script1_lite:491 : No module named 'archicad' (I have no archicad)

sverchok\json_examples\Architecture\BIM_FreeCAD_import.json - errors Looking for GlslTexture 2022-08-24 17:49:18,689 [INFO] sverchok.utils.sv_json_import 320: Import done with no fails 2022-08-24 17:49:18,691 [INFO] sverchok.nodes.exchange.FCStd_read 230: FCStd read error 2022-08-24 17:49:18,691 [ERROR] sverchok.nodes.exchange.FCStd_read:233 : local variable 'doc' referenced before assignment (I do not undestand what it means? I have freeCad library installed and have a menu too)

sverchok\json_examples\Architecture\BIM_truss_joint.json - errors FAIL: Setting advance node properties - 3 2022-08-24 17:50:18,313 [INFO] sverchok.nodes.script.script1_lite 361 (SN: shader2): hash invalidated 2022-08-24 17:50:18,314 [INFO] sverchok.nodes.script.script1_lite 244 (SN: shader2): (None, None, None, None), 0, was unparsable 2022-08-24 17:50:18,316 [INFO] sverchok.nodes.script.script1_lite 303 (SN: shader2): failed to load sockets for inputs 2022-08-24 17:50:18,317 [INFO] sverchok.nodes.script.script1_lite 244 (SN: shader2): (None, None, None, None), 0, was unparsable 2022-08-24 17:50:18,319 [INFO] sverchok.nodes.script.script1_lite 303 (SN: shader2): failed to load sockets for inputs 2022-08-24 17:50:18,319 [ERROR] sverchok.nodes.script.script1_lite:367 : 'NoneType' object is not subscriptable 2022-08-24 17:50:18,322 [INFO] sverchok.nodes.script.script1_lite 361 (SN: shader3): hash invalidated 2022-08-24 17:50:18,323 [INFO] sverchok.nodes.script.script1_lite 244 (SN: shader3): (None, None, None, None), 0, was unparsable 2022-08-24 17:50:18,325 [INFO] sverchok.nodes.script.script1_lite 303 (SN: shader3): failed to load sockets for inputs 2022-08-24 17:50:18,326 [INFO] sverchok.nodes.script.script1_lite 244 (SN: shader3): (None, None, None, None), 0, was unparsable 2022-08-24 17:50:18,327 [INFO] sverchok.nodes.script.script1_lite 303 (SN: shader3): failed to load sockets for inputs 2022-08-24 17:50:18,328 [ERROR] sverchok.nodes.script.script1_lite:367 : 'NoneType' object is not subscriptable 2022-08-24 17:50:18,329 [INFO] sverchok.nodes.script.script1_lite 361 (SN: shader): hash invalidated 2022-08-24 17:50:18,330 [INFO] sverchok.nodes.script.script1_lite 244 (SN: shader): (None, None, None, None), 0, was unparsable 2022-08-24 17:50:18,332 [INFO] sverchok.nodes.script.script1_lite 303 (SN: shader): failed to load sockets for inputs 2022-08-24 17:50:18,333 [INFO] sverchok.nodes.script.script1_lite 244 (SN: shader): (None, None, None, None), 0, was unparsable 2022-08-24 17:50:18,334 [INFO] sverchok.nodes.script.script1_lite 303 (SN: shader): failed to load sockets for inputs 2022-08-24 17:50:18,335 [ERROR] sverchok.nodes.script.script1_lite:367 : 'NoneType' object is not subscriptable (I try to correct Shaders but unsuccessfully)

sverchok\json_examples\Architecture\Coliseum.json - good sverchok\json_examples\Architecture\Curved_Hexagonal_Truss.json - good sverchok\json_examples\Architecture\Fasade_Complicated.json - good

sverchok\json_examples\Architecture\Power_transmission_tower.json - errors Looking for GlslTexture 2022-08-24 17:54:02,098 [INFO] sverchok.utils.sv_json_import 320: Import done with no fails 2022-08-24 17:54:02,350 [ERROR] sverchok.utils.sv_bmesh_utils:108 : edges.get(...): found the same (BMVert) used multiple times (I try understand exception but unsuccessfully)

sverchok\json_examples\Architecture\ProfileBuilding.json - good sverchok\json_examples\Architecture\Tensile_Cover.json - good

== CNC ========================

sverchok\json_examples\CNC\CNC_Bench.json - good sverchok\json_examples\CNC\CNC_CUTHOLES_RESIZE.json - good sverchok\json_examples\CNC\CNC_GCODE.json - good sverchok\json_examples\CNC\CNC_K40Whisperer_Laser.json - good sverchok\json_examples\CNC\CNC_PANNO.json - good sverchok\json_examples\CNC\CNC_SVG_A4.json - good sverchok\json_examples\CNC\CNC_Waffle.json - good

== Design =============================

sverchok\json_examples\Design\Adaptive_per_face.json - good sverchok\json_examples\Design\Adaptive_Voronoi_panel.json - good sverchok\json_examples\Design\Color_Lights.json - good sverchok\json_examples\Design\Inset_Hexagonal_Grid.json - good sverchok\json_examples\Design\KDT_short_path.json - good sverchok\json_examples\Design\rigid_origami.json - good sverchok\json_examples\Design\Twisted_square_origami.json - good sverchok\json_examples\Design\Twisted_square_origami.json - good sverchok\json_examples\Design\Water_bomb_origami_tessellation_namako.json - good sverchok\json_examples\Design\Water_bomb_origami_tessellation_square.json - good

== Fields ===================================

sverchok\json_examples\Fields\Mesh_Attractor.json - good sverchok\json_examples\Fields\Noise_by_Attractor.json - good sverchok\json_examples\Fields\Projection_Decomposition.json - good sverchok\json_examples\Fields\Random_Voronoi.json - good sverchok\json_examples\Fields\RBF_lines.json - good

== Introduction ====================================

sverchok\json_examples\Introduction\ABCnaming.json - good sverchok\json_examples\Introduction\Adaptive_Spread.json - good sverchok\json_examples\Introduction\BentTorus.json - good sverchok\json_examples\Introduction\Circle_Generator.json - good sverchok\json_examples\Introduction\Donut_by_hands.json - good sverchok\json_examples\Introduction\Interpolations.json - good sverchok\json_examples\Introduction\List_multymasking.json - good sverchok\json_examples\Introduction\Orientation_matrix_track_to.json - good sverchok\json_examples\Introduction\Polar_coordinates_curve.json - good sverchok\json_examples\Introduction\Voronoi_Trick.json - good

== Shapes =====================================

sverchok\json_examples\Shapes\Bend_bricks_grid_to_sphere.json - good sverchok\json_examples\Shapes\Blender_logo.json - good sverchok\json_examples\Shapes\Buddha_Lotus.json - good sverchok\json_examples\Shapes\Concave_sverchok.json - good sverchok\json_examples\Shapes\Donut.json - good sverchok\json_examples\Shapes\Holes_in_cone.json - good sverchok\json_examples\Shapes\InsetDodecahedron.json - good

sverchok\json_examples\Shapes\Keyboard_key_profile.json - errors [ERROR] sverchok.utils.modules.polygon_utils:206 : index 2 is out of bounds for axis 1 with size 2

sverchok\json_examples\Shapes\Petal.json - good

sverchok\json_examples\Shapes\Sofa_Pillow.json - errors [ERROR] sverchok.nodes.vector.attractor:114 : 'inverse_cubic'

sverchok\json_examples\Shapes\Sphere_stripes.json - good sverchok\json_examples\Shapes\Spherical_Sverchok_in_vacuum.json - good sverchok\json_examples\Shapes\SverchokLogo.json - good sverchok\json_examples\Shapes\Tie_revange_2020.json - good

== Surfaces ================================================

sverchok\json_examples\Surfaces\Spiral.json - good sverchok\json_examples\Surfaces\Tower.json - good

Solution description

Many nodes are good but some nodes contains errors.

Are some errors are expected?

Ответственный
Назначить
Проверяющие
Запросить ревью
Оценка трудозатрат
Исходная ветка: github/fork/satabol/Branch_update_templates_and_examples_node_names