Oldnode unregister direct (#4154)

* test direct * check direct attrbites of module * dont squash two module types * old_nodes.unregister can test first if the node is registered * use debug * remove comment

Oldnode unregister direct (#4154)
* test direct * check direct attrbites of module * dont squash two module types * old_nodes.unregister can test first if the node is registered * use debug * remove comment
4ebdaeb0 · Dealga McArdle · GitHub · 435e6f74 · 4ebdaeb0 · 4ebdaeb0
--- a/__init__.py
+++ b/__init__.py
@@ -96,6 +96,7 @@ def register():
 def unregister():
    sverchok.utils.clear_node_classes()
-    sv_registration_utils.unregister_all(imported_modules + node_list)
+    sv_registration_utils.unregister_all(imported_modules)
+    sv_registration_utils.unregister_all(node_list)
 # EOF
--- a/core/__init__.py
+++ b/core/__init__.py
@@ -28,14 +28,6 @@ def sv_unregister_modules(modules):
    clear_system_cache()
    for m in reversed(modules):
        if hasattr(m, "unregister"):
-            # print("Unregistering module: {}".format(m.__name__))
-            if m.__name__ == "sverchok.old_nodes":
-                import bpy
-                old_node_names = sverchok.old_nodes.old_bl_idnames
-                loaded = any([hasattr(bpy.types, node_class_name) for node_class_name in old_node_names.keys()])
-                if not loaded:
-                    print("skipping unregister of old nodes..they are not registered")
-                    continue
            try:
                m.unregister()
            except RuntimeError as e:

--- a/old_nodes/__init__.py
+++ b/old_nodes/__init__.py
@@ -27,7 +27,7 @@ import bpy
 from sverchok.node_tree import SverchCustomTreeNode
 from sverchok.utils.sv_oldnodes_parser import get_old_node_bl_idnames
-from sverchok.utils.logging import error, exception
+from sverchok.utils.logging import error, exception, debug
 imported_mods = {}
@@ -148,7 +148,9 @@ def unregister_old(bl_id):
 def unregister():
    global imported_mods
-    print(imported_mods)
+    for key, mod in imported_mods.items():
-    for mod in imported_mods.values():
+        if hasattr(bpy.types, key):
-        mod.unregister()
+            mod.unregister()
+        else:
+            debug(f'{key} was not registered, did not unregister')
    imported_mods = {}