Merge branch 'tchu-refactor-datamigrationservicespec' into 'master'

Small refactor to remove rubocop disable See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119980 Merged-by: Bob Van Landuyt <bob@gitlab.com> Approved-by: Bob Van Landuyt <bob@gitlab.com> Co-authored-by: Terri Chu <tchu@gitlab.com>

Merge branch 'tchu-refactor-datamigrationservicespec' into 'master'
Small refactor to remove rubocop disable See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119980 Merged-by: Bob Van Landuyt <bob@gitlab.com> Approved-by: Bob Van Landuyt <bob@gitlab.com> Co-authored-by: Terri Chu <tchu@gitlab.com>
7b0baa83 · Bob Van Landuyt · b373dd95 · b6b2464b · 7b0baa83
--- a/ee/spec/services/elastic/data_migration_service_spec.rb
+++ b/ee/spec/services/elastic/data_migration_service_spec.rb
@@ -233,7 +233,8 @@
      end
      after do
-        Elastic::DataMigrationService.mark_all_as_completed! # rubocop: disable RSpec/DescribedClass
+        # reset migration index to prevent flakiness
+        described_class.mark_all_as_completed!
      end
      it 'returns true' do
@@ -258,7 +259,8 @@
    end
    after do
-      Elastic::DataMigrationService.mark_all_as_completed! # rubocop: disable RSpec/DescribedClass
+      # reset migration index to prevent flakiness
+      described_class.mark_all_as_completed!
    end
    it 'returns only pending migrations' do