Remove duplicated avatars in approvals merge request widget

Changelog: changed

Remove duplicated avatars in approvals merge request widget
Changelog: changed
0e95ec52 · Sascha Eggenberger · ea4c60ae · 0e95ec52
--- a/ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_list.vue
+++ b/ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_list.vue
@@ -116,6 +116,11 @@ export default {
        ? DO_NOT_INCLUDE_APPROVERS
        : INCLUDE_APPROVERS;
    },
+    eligibleApproversNotApprovedYet(rule) {
+      return rule.eligibleApprovers.filter(
+        (x) => !rule.approvedBy.nodes.some((y) => x.id === y.id),
+      );
+    },
  },
  ruleTypeAnyApprover: RULE_TYPE_ANY_APPROVER,
 };
@@ -210,7 +215,7 @@ export default {
              <user-avatar-list
                v-if="!rule.fallback"
                class="mt-2"
-                :items="rule.eligibleApprovers"
+                :items="eligibleApproversNotApprovedYet(rule)"
                :img-size="24"
                empty-text=""
              />
@@ -241,7 +246,7 @@ export default {
            class="d-md-table-cell d-none gl-w-full js-approvers"
          >
            <user-avatar-list
-              :items="rule.eligibleApprovers"
+              :items="eligibleApproversNotApprovedYet(rule)"
              :img-size="24"
              empty-text=""
              class="gl-display-flex gl-flex-wrap"