shouldPersist was not being set on RemoteTerminalProcess, causing reconnect
to fail for all remote terminals. The fix was to push the persistent logic
up to where the process gets created in TerminalProcessManager just like is
done with local processes. The property was made non-optional to prevent
this sort of thing happening again.

Part of #117896